fix: preserve reporter options from config when CLI reporters override them #8794
+49
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where reporter options defined in the config file were being ignored when the reporter was specified via CLI flags.
Problem
When users configured a reporter in their
vitest.config.tswith specific options:And then ran vitest with the CLI reporter flag (e.g., to run only JUnit in CI):
The reporter options (
suiteName,addFileAttribute, etc.) from the config were completely ignored, and the reporter would use default options instead.Solution
Modified the reporter resolution logic in
resolveConfig.tsto preserve options from the config file when CLI reporters are specified. The fix:This ensures that users can:
Example
With this fix, running:
Will now correctly use the
suiteName,addFileAttribute, and other options defined in the config file, producing the expected XML output with custom suite names and file attributes.Testing
Closes #7535
Original prompt
vitest --reporter junitdoes not pick up the options defined in the config file #8774💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.